Add `acme.py` changes from PR #712

E3SM-Project / e3sm_diags

E3SM Diagnostics package

https://e3sm-project.github.io/e3sm_diags

BSD 3-Clause "New" or "Revised" License

38 stars 31 forks source link

Add `acme.py` changes from PR #712 #814

Closed tomvothecoder closed 3 months ago

tomvothecoder commented 3 months ago

Closes #813

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

If applicable:

[ ] New and existing unit tests pass with my changes (locally and CI/CD build)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

tomvothecoder commented 3 months ago

Hey @chengzhuzhang, can you open up GitHub issues for any changes to acme.py on the main branch (e.g., PR #712)? I've been running into a few issues while refactoring cdat-migration-fy24 dev branches because the derived variables become out of sync with derivations.py and formulas.py.

I'll probably remember to do this too if I'm tagged as a PR reviewer and see acme.py is updated. Thanks!

chengzhuzhang commented 3 months ago

Thanks for the reminder! Yes, we should do that. And hopefully, we don't have to live with two parallel development branches for too long!