Closed tomvothecoder closed 2 months ago
Hey @chengzhuzhang, just an FYI that I added functionality to replicate the cdms2
"ccb
flag for non-submonthly data (#759).
I tested ex1.py
which uses time series data and all of the results check out except one (new issue #817). You can refer to the above review comment for more info.
You can review the new code for this functionality here in dataset_xr.py
: https://github.com/E3SM-Project/e3sm_diags/pull/750/files#diff-35006a05805f6f5876c9fe70b5281c865955b8a82d1574fd7f62d6efda623975
@tomvothecoder great work to support the slice flag and match the results with main! Also thanks for careful documentation on the final straggler and I agree that we should address in a separate PR..
Description
5/30/24
ex1.py
and perform regression test againNET_FLUX_SRF
andRESTOM
had the largest diffs with the slice flag -- now fixed_subset_on_region()
(need to pass objects with land mask applied)TREFHT
land mean ref regridded data (11.59% diff) -- address this later in a separate GH issue (#817)Checklist
If applicable: