Fix a variable name displayed in viewer

E3SM-Project / e3sm_diags

E3SM Diagnostics package

https://e3sm-project.github.io/e3sm_diags

BSD 3-Clause "New" or "Revised" License

38 stars 31 forks source link

Fix a variable name displayed in viewer #820

Closed chengzhuzhang closed 1 month ago

chengzhuzhang commented 1 month ago

Description

related to #818

Checklist

[x ] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x ] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

If applicable:

[ ] New and existing unit tests pass with my changes (locally and CI/CD build)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

chengzhuzhang commented 1 month ago

@kchong75 this change should fix the incorrect name displayed. Please have a review and let me know if there is any questions.

@tomvothecoder this fix again needs to be brought into cdat migration branch. Maybe we should create a label for this type of fix, so that we can group them when updating cdat-migration-fy24?

kchong75 commented 1 month ago

@kchong75 this change should fix the incorrect name displayed. Please have a review and let me know if there is any questions.

Thank you for fixing it! The name looks correct now.

tomvothecoder commented 1 month ago

@tomvothecoder this fix again needs to be brought into cdat migration branch. Maybe we should create a label for this type of fix, so that we can group them when updating cdat-migration-fy24?

I added the GH issue (#818) to the project board and labeled it with cdat-migration-fy24.

One caveat is that closing the GH issue will move it to "Done" on the project board unless we open a duplicate issue specifically for the dev branch.