CDAT Migration Phase 2: Refactor `qbo` set - Githubissues

E3SM-Project / e3sm_diags

E3SM Diagnostics package

https://e3sm-project.github.io/e3sm_diags

BSD 3-Clause "New" or "Revised" License

42 stars 32 forks source link

CDAT Migration Phase 2: Refactor `qbo` set #826

Closed tomvothecoder closed 3 months ago

tomvothecoder commented 4 months ago

Closes #664

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

If applicable:

[x] New and existing unit tests pass with my changes (locally and CI/CD build)
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

tomvothecoder commented 3 months ago

@chengzhuzhang Here are the plots. The diff plot shows a really small diff. I think this PR is good to merge after I fix the plot titles and unit tests.

Dev	Main	Diff

Source: https://portal.nersc.gov/project/e3sm/cdat-migration-fy24/664-qbo/qbo/