Drop support for python 3.8

E3SM-Project / e3sm_diags

E3SM Diagnostics package

https://e3sm-project.github.io/e3sm_diags

BSD 3-Clause "New" or "Revised" License

42 stars 32 forks source link

Drop support for python 3.8 #844

Closed altheaden closed 2 months ago

altheaden commented 2 months ago

Description

Python 3.8 is no longer supported by conda-forge, so I removed references to it from setup.py.

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

xylar commented 2 months ago

@chengzhuzhang, @tomvothecoder and @forsyth2, I've tasked @altheaden with looking around at various E3SM python packages for python 3.8. It was dropped recently on conda-forge so we probably can't safely support it anymore: https://github.com/conda-forge/conda-forge-pinning-feedstock/issues/5013

xylar commented 2 months ago

@tomvothecoder, can you check if failing CI is something we did here or if it's a pre-existing problem?

xylar commented 2 months ago

It looked like it was maybe just a timeout to the LCRC server. I'll try again.

chengzhuzhang commented 2 months ago

@xylar @altheaden thanks for working on this!

xylar commented 2 months ago

Thanks @tomvothecoder and @chengzhuzhang!