Closed altheaden closed 2 months ago
@altheaden, it looks like cancel others is still on here. Do you want to change that, too? Then, we can ask @tomvothecoder and @chengzhuzhang what they think of the changes in general.
@xylar Whoops, definitely a mistake, thanks for catching that! Fixed.
One more note, if you're happy with these changes, @altheaden will make similar ones for zppy and zstash.
@altheaden Thanks for working on this!
@xylar From visual inspection alone, these changes seem fine for zppy and zstash too, thanks.
Great, let's make sure @tomvothecoder agrees since he wrote these workflows in the first place.
Hi @altheaden and @xylar, these changes look reasonable to me. I'm happy to have this PR merged. Thanks @altheaden!
@chengzhuzhang, it sounds like you can merge then if you're also happy.
It looks good to me. Thank you for this update @altheaden @xylar !
Description
Hello! With this PR I've tweaked some settings that @xylar and I have determined work out better in CI workflows on other repos. I've made the same changes here. These changes include:
cancel_others
is now set to false by default, which should make it easier to decipher if a bug is isolated to a specific version of python via CImamba
/Mambaforge
have been removed and/or changed toconda
/Miniforge3
pre-commit
job has been upped to 5 minutes (we were having some timeout issues during the caching step)Checklist