E3SM-Project / e3sm_diags

E3SM Diagnostics package
https://e3sm-project.github.io/e3sm_diags
BSD 3-Clause "New" or "Revised" License
42 stars 32 forks source link

Tweak behaviors of build and release CI workflows #847

Closed altheaden closed 2 months ago

altheaden commented 2 months ago

Description

Hello! With this PR I've tweaked some settings that @xylar and I have determined work out better in CI workflows on other repos. I've made the same changes here. These changes include:

  1. cancel_others is now set to false by default, which should make it easier to decipher if a bug is isolated to a specific version of python via CI
  2. All references to mamba/ Mambaforge have been removed and/or changed to conda / Miniforge3
  3. The timeout for the pre-commit job has been upped to 5 minutes (we were having some timeout issues during the caching step)

Checklist

xylar commented 2 months ago

@altheaden, it looks like cancel others is still on here. Do you want to change that, too? Then, we can ask @tomvothecoder and @chengzhuzhang what they think of the changes in general.

altheaden commented 2 months ago

@xylar Whoops, definitely a mistake, thanks for catching that! Fixed.

xylar commented 2 months ago

One more note, if you're happy with these changes, @altheaden will make similar ones for zppy and zstash.

forsyth2 commented 2 months ago

@altheaden Thanks for working on this!

@xylar From visual inspection alone, these changes seem fine for zppy and zstash too, thanks.

xylar commented 2 months ago

Great, let's make sure @tomvothecoder agrees since he wrote these workflows in the first place.

tomvothecoder commented 2 months ago

Hi @altheaden and @xylar, these changes look reasonable to me. I'm happy to have this PR merged. Thanks @altheaden!

xylar commented 2 months ago

@chengzhuzhang, it sounds like you can merge then if you're also happy.

chengzhuzhang commented 2 months ago

It looks good to me. Thank you for this update @altheaden @xylar !