Add function to add CF axis attr to Z axis if missing for downstream xCDAT operations - Githubissues

E3SM-Project / e3sm_diags

E3SM Diagnostics package

https://e3sm-project.github.io/e3sm_diags

BSD 3-Clause "New" or "Revised" License

42 stars 32 forks source link

Add function to add CF axis attr to Z axis if missing for downstream xCDAT operations #865

Closed tomvothecoder closed 1 month ago

tomvothecoder commented 1 month ago

Description

Closes #863 863
This is a temporary workaround for variables that have Z axes without CF axis attr, which is required for xCDAT to map to for bounds for downstream operations such as regridding

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

If applicable:

[x] New and existing unit tests pass with my changes (locally and CI/CD build)
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

chengzhuzhang commented 1 month ago

@tomvothecoder Thank you for coming up with this temporary workaround! We can later update once xcdat has this fix.