E3SM-Project / e3sm_diags

E3SM Diagnostics package
https://e3sm-project.github.io/e3sm_diags
BSD 3-Clause "New" or "Revised" License
42 stars 32 forks source link

Add fix for checking `is_time_series()` property based on `data_type` attr #881

Closed tomvothecoder closed 3 weeks ago

tomvothecoder commented 3 weeks ago

Description

Checklist

If applicable:

tomvothecoder commented 3 weeks ago

@chengzhuzhang This PR should fix the attribute error (tested with your run script). You can rebase your eamxx_1024 branch on the latest cdat-migration-fy24

EDIT: Actually let me address a few more of the open issues in #871 first so you don't have to keep rebasing.

chengzhuzhang commented 3 weeks ago

@tomvothecoder thank you. I will keep modifying eamxx_1024, the changes are mostly contained within variable derivation, so it is easy to rebase.