Remove positive from hfsifrazil

E3SM-Project / e3sm_to_cmip

Tools to CMORize E3SM output

https://e3sm-to-cmip.readthedocs.io/en/latest/

MIT License

7 stars 7 forks source link

Remove positive from hfsifrazil #278

Closed xylar closed 2 months ago

xylar commented 2 months ago

Description

This fixes the issue mentioned in https://github.com/E3SM-Project/e3sm_to_cmip/pull/270#issuecomment-2339303713

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings

If applicable:

[ ] New and existing unit tests pass with my changes (locally and CI/CD build)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

xylar commented 2 months ago

@TonyB9000, I don't have the means to test this so I'll count on you.

TonyB9000 commented 2 months ago

@xylar Looks Good. I just re-ran CMIP6.CMIP.E3SM-Project.E3SM-2-1.1pctCO2.r1i1p1f1.Omon.hfsifrazil.gr (1 year) and the cmor log output no longer has the warning:

Warning: variable 'hfsifrazil' (table Omon) you passed positive value:down, but table does not mention it, will be ignored, if you really want this in your variable output use cmor_set_variable_attribute_internal function.

Next Steps? Do you "squash and merge"? Do I? Does it matter? (my ignorance is showing).

xylar commented 2 months ago

You or @chengzhuzhang should merge, as I don't know the policies for this repo.

TonyB9000 commented 2 months ago

@xylar Policies? Ha! (merging and deleting branch.)

TonyB9000 commented 2 months ago

@xylar I guess only you can delete the branch - I get no opportunity.

xylar commented 2 months ago

@TonyB9000, I'd have to make you a collaborator on my fork to allow you to delete my branches. That's probably more trouble than it's worth. I can delete them.

TonyB9000 commented 2 months ago

@xylar No issue. I am just in the habit of deleting closed branches to reduce the clutter. This is my first time dealing in someone else's fork - so I am ignorant of the protocols.