E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Update to v0.2.0 #103

Closed xylar closed 1 year ago

xylar commented 1 year ago

This merge brings over many of the changes from the compass PR https://github.com/MPAS-Dev/compass/pull/641. This includes:

It also switches unknown machines to using the conda-forge versions of libpnetcdf and parallelio, which are newly available.

Checklist

Deployed

MPAS-Ocean with pr:

xylar commented 1 year ago

I tried to do a spack build on my Mac laptop but I'm having some pretty fundamental trouble with bash on the Mac and wasn't able to get Spack to behave.

xylar commented 1 year ago

@altheaden, this worked for me on the Mac, at least up to the point of building MPAS-Ocean. I'm still doing that so haven't actually run tests yet.

Please let me know if it works for you. You'll want to check out this branch and run:

./configure_polaris_envs.py --recreate --verbose

and optionally additional options like --env_name and --conda if you need them.

Update: I was able to run most of the pr suite on my Mac (3 tests failed because I only have 4 cores).

xylar commented 1 year ago

Testing

I was able to run the pr suite on Perlmutter and on my Linux and Mac laptops (except for tests that are too big). I'll be testing on all machines as part of deploying the spack environment.

altheaden commented 1 year ago

@xylar I am able to make the environment when I use your branch, without issue. I'll build and run the PR suite now and see how everything looks on my end.

altheaden commented 1 year ago

@xylar I'm having some make errors, and I'm not sure if it's related to these issues or something specific to my mac. Here's what I'm seeing:

make clean && make gfortran-clang
...
mpas_io.F:280:41:

  280 |             pio_iotype = PIO_iotype_adios
      |                                         1
Error: Symbol ‘pio_iotype_adios’ at (1) has no IMPLICIT type; did you mean ‘pio_iotype’?
make[3]: *** [Makefile:126: mpas_io.o] Error 1
make[3]: Leaving directory '/Users/althea/polaris/main/e3sm_submodules/E3SM-Project/components/mpas-framework/src/framework'
make[2]: *** [Makefile:26: frame] Error 2
make[2]: Leaving directory '/Users/althea/polaris/main/e3sm_submodules/E3SM-Project/components/mpas-framework/src'
make[1]: *** [Makefile:1035: framework] Error 2
make[1]: Leaving directory '/Users/althea/polaris/main/e3sm_submodules/E3SM-Project/components/mpas-ocean'
make: *** [Makefile:323: gfortran-clang] Error 2

Prior to this I updated the submodules, and then I tried deleting and re-updating the submodule folder, and still no luck.

xylar commented 1 year ago

@altheaden, can you check to see if the following is in your load script?

export HAVE_ADIOS=false

Also, are you using the submodule from within the update-to-0.2.0 worktree or the one from main? If the latter, it might not be updated enough. (This is a special situation where I updated E3SM-Project in this PR so you can't use the one from main.)

altheaden commented 1 year ago

@xylar I was updating the ones in main, so I'll just update them all from this branch and make there. I do see that line in the load script for the branch! I will update you in a while after the submodules are up to date.

altheaden commented 1 year ago

@xylar I was able to build and run everything, and the only test that failed is the ocean/inertial_gravity_wave/convergence test. Do you want me to do any additional testing on the mac? I can send the log file for the inertial gravity test if that seems like it was supposed to pass - not sure if that's just a resources issue or what.

xylar commented 1 year ago

@altheaden, sounds fine. That's the test that failed for me on my laptop, too. It needs a minimum of 32 cores for the highest resolution forward step so it won't work on laptops in general. Nothing to worry about.

Thanks for testing!

xylar commented 1 year ago

@cbegeman, is this something you want to test (and have time to test)? Or would you be happy trusting my testing and @altheaden's?

cbegeman commented 1 year ago

@cbegeman, is this something you want to test (and have time to test)? Or would you be happy trusting my testing and @altheaden's?

I'm happy to trust your and @altheaden's testing. I don't have time to contribute to testing this week.

altheaden commented 1 year ago

Since the LCRC servers are back online now, I will continue some testing on chrysalis and anvil.

xylar commented 1 year ago

@altheaden, I'm just waiting for your approval to merge. If you have already done LCRC testing, great! Otherwise, your Mac testing is plenty.

altheaden commented 1 year ago

I tested on Chrysalis with intel and openmpi and everything worked as expected.