E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Add support for shared steps #116

Closed xylar closed 1 year ago

xylar commented 1 year ago

This merge adds support to the polaris framework for shared steps (steps that can belong to more than one task). Existing tasks and steps are modified to accommodate the changes to the framework but tasks and steps are not yet reorganized to take advantage of shared steps so that bit-for-bit comparison with main can still be made with this branch.

Changes to Step include:

Changes to Component include:

Changes to Task include:

Other changes include:

Checklist and changes look as expected

xylar commented 1 year ago

Testing

I have run all test cases except 1 and 4 km RPE tests and made sure results are BFB with main.

xylar commented 1 year ago

I don't plan on updating the documentation here. Instead, I will do that in #117

xylar commented 1 year ago

@cbegeman, thanks very much for the review. These are all great suggestions, which I will make tomorrow.

xylar commented 1 year ago

@cbegeman, I believe I've addressed your 3 requested changes. Please have another look when you have time.

xylar commented 1 year ago

@cbegeman, thanks for looking it over again. I think we're good for now. Let's see what @sbrus89 says.

xylar commented 1 year ago

@sbrus89, thanks so much for your comments! I appreciate you taking a look. Let me know if I've addressed your comments or if you'd like to see more changes.

xylar commented 1 year ago

Thanks so much!