E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Reorganize tasks to use shared steps #117

Closed xylar closed 1 year ago

xylar commented 1 year ago

This is the follow-up to #116 that actually reorganizes the test cases to use shared steps and that changes to the proposed new work-directory structure.

This branch builds on #116 to implements the design described in #109.

Tasks in the work directory are organized into planar and spherical (currently only cosine_bell).

Under planar, tests are largely organized as they were before except that:

Under spherical:

I went through the entire documentation (it took a full day) and it seems like it's in pretty good shape now.

Checklist

xylar commented 1 year ago

Testing

I successfully ran all test cases except RPE 1 km and 4 km on Chrysalis. I will rerun once more before merging to make sure changes during updating the docs and review don't inadvertently affect the results.

xylar commented 1 year ago

@sbrus89, do you know if that issue (Index '2' of dimension 1 of array 'tracercur' above upper bound of 1) is new in this PR or if that's always been present? It seems like it's a problem of not having initialized 3 debug tracers, and that didn't change here as far as I know.

xylar commented 1 year ago

Hmm, I really don't get that error because we do initialize all three debug tracers to the same value. Is it possible that error was introduced in MPAS-Ocean and is unrelated to Polaris? But then why don't we see it in Compass? Mysterious!

xylar commented 1 year ago
Error termination. Backtrace:
At line 689 of file mpas_ocn_tracer_advection_mono.F
Fortran runtime error: Index '2' of dimension 1 of array 'tracercur' above upper bound of 1

This appears to be an issue with indexing for single-layer runs. Maybe no one has been running in debug mode with single layer? In any case, it seems like that particular line in MPAS-O hasn't been changed in 2 years so I don't think it's a new issue and I don't think it's introduced here. Can you verify that you see it with main? If so, I would suggest we make an E3SM issue about it since it doesn't seem to be a Polaris problem as far as I can tell.

xylar commented 1 year ago

Thanks @sbrus89! Do you have time to make an E3SM issue for this? I'd hate for us to lose track of it. Presumably, we should add a single-layer test to the Compass pr suite so this gets flagged in testing that is regularly done on E3SM, since Polaris is not used that way yet.