Closed xylar closed 1 year ago
I successfully ran all test cases except RPE 1 km and 4 km on Chrysalis. I will rerun once more before merging to make sure changes during updating the docs and review don't inadvertently affect the results.
@sbrus89, do you know if that issue (Index '2' of dimension 1 of array 'tracercur' above upper bound of 1
) is new in this PR or if that's always been present? It seems like it's a problem of not having initialized 3 debug tracers, and that didn't change here as far as I know.
Hmm, I really don't get that error because we do initialize all three debug tracers to the same value. Is it possible that error was introduced in MPAS-Ocean and is unrelated to Polaris? But then why don't we see it in Compass? Mysterious!
Error termination. Backtrace:
At line 689 of file mpas_ocn_tracer_advection_mono.F
Fortran runtime error: Index '2' of dimension 1 of array 'tracercur' above upper bound of 1
This appears to be an issue with indexing for single-layer runs. Maybe no one has been running in debug mode with single layer? In any case, it seems like that particular line in MPAS-O hasn't been changed in 2 years so I don't think it's a new issue and I don't think it's introduced here. Can you verify that you see it with main
? If so, I would suggest we make an E3SM issue about it since it doesn't seem to be a Polaris problem as far as I can tell.
Thanks @sbrus89! Do you have time to make an E3SM issue for this? I'd hate for us to lose track of it. Presumably, we should add a single-layer test to the Compass pr
suite so this gets flagged in testing that is regularly done on E3SM, since Polaris is not used that way yet.
This is the follow-up to #116 that actually reorganizes the test cases to use shared steps and that changes to the proposed new work-directory structure.
This branch builds on #116 to implements the design described in #109.
Tasks in the work directory are organized into
planar
andspherical
(currently onlycosine_bell
).Under
planar
, tests are largely organized as they were before except that:baroclinic_channel
uses sharedinit
steps for each resolutioninertial_gravity_wave
andmanufactured_soluion
are now the names of tasks (there is no longer a singleconvergence
task within each)nx
, andny
are now config options insingle_column
(rather thanlx
andly
), and there is no subdirectory for resolutionUnder
spherical
:icos
andqu
(with other meshes and mesh types to come later)base_mesh/<res>km
steps withinocean/spherical/icos
andocean/spherical/qu
.cosine_bell
tasks use the sharedbase_mesh/*
steps, and make local symlinks to each res under their ownbase_mesh
subdirectory (so that the organization looks much like before)cosine_bell/with_viz
tasks share thesebase_mesh/*
steps, and they also share theinit/*
,forward/*
andanalysis
steps withcosine_bell
tasks. They make local symlinks so it should be clear. See the updated docs and the design doc in #109 for more details.I went through the entire documentation (it took a full day) and it seems like it's in pretty good shape now.
Checklist
api.md
) has any new or modified class, method and/or functions listedTesting
comment in the PR documents testing used to verify the changes