E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Clean up RPE analysis step and framework #123

Closed xylar closed 1 year ago

xylar commented 1 year ago

Rather than using some iffy custom plotting techniques, this uses the framework plot_horiz_field() function.

This merge also fix a bug in the placement of nu being added to model config options. Before this fix, the forward.yaml options were overwriting the nu value so all RPE runs used the same viscosity. This problem was introduced in the initial port of baroclinic channel (https://github.com/E3SM-Project/polaris/commit/875e7fe6b6e3a34939adeacb4594ab9e07ec5f17) but apparently after initial testing showed that it worked as expected.

Checklist

xylar commented 1 year ago

Testing

I successfully ran the 10 km RPE test on Chrysalis. The updated output is: sections_baroclinic_channel_10 0 rpe_t

For reference, old output from #27 was: image image

xylar commented 1 year ago

@cbegeman, a quick review by inspection would be appreciated.

It might be nice to add the ability to share y labels and have a single colorbar like in the original plot, but that isn't a high priority for me right now.