Closed cbegeman closed 1 year ago
The icos cosine_bell case has been run and it has machine-precision level diffs with main due to the great circle computation.
@xylar This is now rebased on https://github.com/E3SM-Project/polaris/pull/126 and ready for review, though you can wait until after that one is merged.
@cbegeman, I'm happy to review this once it gets rebased onto main
.
@xylar It's rebased. Thanks for reviewing!
Please merge when you're reandy.
@xylar Thank you for reviewing!
This PR replaces the great circle distance computation in
cosine_bell
with that in MPAS-Tools. It is based on https://github.com/E3SM-Project/polaris/pull/126.Checklist
api.md
) has any new or modified class, method and/or functions listedTesting
comment in the PR documents testing used to verify the changesUser's Guide has been updatedDeveloper's Guide has been updatedNew tests have been added to a test suite