E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Use MPAS-Tools for great circle distance in cosine bell tests #127

Closed cbegeman closed 1 year ago

cbegeman commented 1 year ago

This PR replaces the great circle distance computation in cosine_bell with that in MPAS-Tools. It is based on https://github.com/E3SM-Project/polaris/pull/126.

Checklist

cbegeman commented 1 year ago

Testing

The icos cosine_bell case has been run and it has machine-precision level diffs with main due to the great circle computation.

cbegeman commented 1 year ago

@xylar This is now rebased on https://github.com/E3SM-Project/polaris/pull/126 and ready for review, though you can wait until after that one is merged.

xylar commented 1 year ago

@cbegeman, I'm happy to review this once it gets rebased onto main.

cbegeman commented 1 year ago

@xylar It's rebased. Thanks for reviewing!

xylar commented 1 year ago

Please merge when you're reandy.

cbegeman commented 1 year ago

@xylar Thank you for reviewing!