E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Clean up and add method to spherical convergence analysis #130

Closed xylar closed 1 year ago

xylar commented 1 year ago

This merge adds a polaris.mpas module that has:

This merge also adds a get_output_field() method to SphericalConvergenceAnalysis that can be overridden to compute fields based on MPAS output. This is useful, for example, in #120, where I need to compute the water column thickness (not an output variable from MPAS-Ocean) based on the ssh and bottomDepth variables.

Checklist

xylar commented 1 year ago

Testing

I ran #120, which is based off of this branch. All tasks and steps including analysis run successfully with these changes:

QU: convergence_normalVelocity convergence_h

Icosahedral: convergence_normalVelocity convergence_h

xylar commented 1 year ago

The order of convergence is slightly better with area-weighting, which is interesting.

xylar commented 1 year ago

@cbegeman, no rush but I decided to break this out of #120 to keep thing cleaner. I think this should be quick to review by inspection.

xylar commented 1 year ago

Thank you, @cbegeman!