Closed xylar closed 1 year ago
I ran #120, which is based off of this branch. All tasks and steps including analysis run successfully with these changes:
QU:
Icosahedral:
The order of convergence is slightly better with area-weighting, which is interesting.
@cbegeman, no rush but I decided to break this out of #120 to keep thing cleaner. I think this should be quick to review by inspection.
Thank you, @cbegeman!
This merge adds a
polaris.mpas
module that has:area
module that currently has a functionarea_for_field()
for computing the area associated with a given data array from and MPAS output file. This is useful for getting different areas for fields on cells, edges and vertices.time
module where I have movedtime_index_from_xtime()
. I also added an optionalstart_xtime
argument in case the start time isn't written to the output file.SphericalConvergenceAnalysis
has been updated to use these.This merge also adds a
get_output_field()
method toSphericalConvergenceAnalysis
that can be overridden to compute fields based on MPAS output. This is useful, for example, in #120, where I need to compute the water column thickness (not an output variable from MPAS-Ocean) based on thessh
andbottomDepth
variables.Checklist
api.md
) has any new or modified class, method and/or functions listedTesting
comment in the PR documents testing used to verify the changes