Closed cbegeman closed 1 year ago
I have run the following convergence tests on chrys with intel, openmpi:
I reran the convergence tests on perlmutter with gnu, mpich.
@xylar Can you take a look at this when you have a chance and let me know if you are on board with these changes before I write up the documentation?
@xylar Thanks for the detailed review! I'm on board with all the changes. I'll make them and retest this week.
@xylar This is ready for your (re)review. I also added a convergence suite which is convenient for testing changes to the convergence steps.
@cbegeman, if you want to either clarify or remove the print statement I flagged above, I think that's the last thing needed before this can be merged.
@xylar Thank you for your review! I removed the print statement and will merge once the checks are finished.
This PR makes it possible for all convergence tests to leverage shared convergence steps and implements those shared convergence steps in all convergence tests.
The general approach is that spherical test cases will invoke
SphericalConvergenceForward
, which descends fromConvergenceForward
, andConvergenceAnalysis
and that planar test cases will invokeConvergenceForward
andConvergenceAnalysis
.The config options are moved into
convergence
andconvergence_forward
and only the default resolutions remain inspherical_convergence_forward
.Checklist
api.md
) has any new or modified class, method and/or functions listedTesting
comment in the PR documents testing used to verify the changes