E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Enhance shared convergence steps #131

Closed cbegeman closed 1 year ago

cbegeman commented 1 year ago

This PR makes it possible for all convergence tests to leverage shared convergence steps and implements those shared convergence steps in all convergence tests.

The general approach is that spherical test cases will invoke SphericalConvergenceForward, which descends from ConvergenceForward, and ConvergenceAnalysis and that planar test cases will invoke ConvergenceForward and ConvergenceAnalysis.

The config options are moved into convergence and convergence_forward and only the default resolutions remain in spherical_convergence_forward.

Checklist

cbegeman commented 1 year ago

Testing

I have run the following convergence tests on chrys with intel, openmpi:

I reran the convergence tests on perlmutter with gnu, mpich.

cbegeman commented 1 year ago

@xylar Can you take a look at this when you have a chance and let me know if you are on board with these changes before I write up the documentation?

cbegeman commented 1 year ago

@xylar Thanks for the detailed review! I'm on board with all the changes. I'll make them and retest this week.

cbegeman commented 1 year ago

@xylar This is ready for your (re)review. I also added a convergence suite which is convenient for testing changes to the convergence steps.

xylar commented 1 year ago

@cbegeman, if you want to either clarify or remove the print statement I flagged above, I think that's the last thing needed before this can be merged.

cbegeman commented 1 year ago

@xylar Thank you for your review! I removed the print statement and will merge once the checks are finished.