E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Fix `steps_to_run` for shared config files #134

Closed xylar closed 1 year ago

xylar commented 1 year ago

With this merge, each task that uses a shared config file used by a task to be set up has its configure() method called and then steps_to_run is added to the shared config options. This prevents a situation where steps_to_run is missing when a task is set up later that overwrites the shared config file.

Checklist

xylar commented 1 year ago

This should fix https://github.com/E3SM-Project/polaris/pull/120#issuecomment-1759697664.

xylar commented 1 year ago

Testing

I set up:

polaris setup -t ocean/spherical/icos/cosine_bell -p ../main/e3sm_submodules/E3SM-Project/components/mpas-ocean/ -w $POLARIS_SCRATCH/cosine-bell
polaris setup -t ocean/spherical/icos/cosine_bell/with_viz -p ../main/e3sm_submodules/E3SM-Project/components/mpas-ocean/ -w $POLARIS_SCRATCH/cosine-bell

Then, I ran:

cd $POLARIS_SCRATCH/cosine-bell/ocean/spherical/icos/cosine_bell
sbatch job_script.sh

This worked with this branch whereas a similar test failed in https://github.com/E3SM-Project/polaris/pull/120#issuecomment-1759697664

xylar commented 1 year ago

@sbrus89, thank you for finding this problem. Please let me know if this fixes it for you.

xylar commented 1 year ago

@sbrus89, same here, I'm going to count on my testing and not waste your time.