E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Port most of the compass framework #14

Closed xylar closed 1 year ago

xylar commented 1 year ago

This merge brings over a good portion of the compass framework. It also:

Checklist

xylar commented 1 year ago

Testing

I have build the documentation locally. While there are many complaints about missing sphinx redirects (because of missing documentation yet to be ported), it builds and has no other errors I noticed.

I have built conda and spack environments on Chrysalis using ./configure_polaris_env.py and have used it to successfully run both cosine bell test cases (QU and Icos).

Here is the configure command I used:

SCRATCH=/lcrc/group/e3sm/ac.xylar
./configure_polaris_envs.py \
    --conda ~/chrysalis/mambaforge/  \
    --env_name polaris_test  \
    --update_spack  \
    --mache_fork xylar/mache  \
    --mache_branch fix_chrysalis_os  \
    --recreate  \
    --spack $SCRATCH/spack_test  \
    --tmpdir $SCRATCH/spack_temp \
xylar commented 1 year ago

@cbegeman, this is a monstrosity . Would you be willing to review it in some capacity? Perhaps a minimum might be to run the configure script, similarly to what I did above (building the spack env takes many hours), build the docs locally, and see if you can also run the cosine bell. Anything more substantial would be up to you. There are bound to be errors in both the docs and the code port but it is so many files (71 currently) that you can't hope to look over even a small fraction of them.

cbegeman commented 1 year ago

@xylar I'd be happy to review!

xylar commented 1 year ago

The mache branch I was testing with got merged, so now the instructions would be:

SCRATCH=/lcrc/group/e3sm/${USER}
./configure_polaris_envs.py \
    --conda ~/mambaforge/  \
    --env_name polaris_test  \
    --update_spack  \
    --mache_fork E3SM-Project/mache  \
    --mache_branch main  \
    --recreate  \
    --spack $SCRATCH/spack_test  \
    --tmpdir $SCRATCH/spack_temp
cbegeman commented 1 year ago

@xylar I have pushed a few commits that make the cosine bell case a bit more suitable as an "ideal" test case, as we discussed. Please edit or request edits as needed. I confirmed that the diffs introduced by the initial state for the cosine bell case are similar to those in https://github.com/MPAS-Dev/compass/pull/519.

xylar commented 1 year ago

@cbegeman, your additions look great to me! I just want to run the tests one last time to do my due diligence.

xylar commented 1 year ago

I reran my tests on Chrysalis with @cbegeman's 4 new commits and everything looks great!