search

E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Fix issues with shared config files #157

Closed xylar closed 10 months ago

xylar commented 10 months ago

This merge fixes two main issues with shared config files:

  1. The main one is adding an explicit attribute of steps to indicate whether they have a shared config (the alternative being that they use the config for the task they belong to). Previously, a step was assumed to have a shared config if it belonged to multiple tasks but that causes trouble when a conceptually shared step happens to belong to only one task (e.g. because other tasks may use it in the future).
  2. The minor fix is that only the tasks and steps requested during setup have their config files linked. Previously, symlinks to the shared config were being created for all tasks and steps that used the config, even if they were not requested at setup. This created confusing directories for unrequested tasks that just had a symlink to the config file.

Checklist

xylar commented 10 months ago

Testing

I ran all ocean test cases except the 1 and 4 km baroclinic channel RPE tests (which are too expensive) on Chrysalis with Intel and OpenMPI. All tests were successful except manufactured solution, which failed the usual verification test.

I also tested #141 after rebasing onto this branch and it fixed the issues with the inception, wetting and drying tests that had previously been seen, see https://github.com/E3SM-Project/polaris/pull/141#issuecomment-1811081405

xylar commented 10 months ago

@cbegeman, can you just give this a quick review, probably just by inspection since I think my testing is sufficient?

xylar commented 10 months ago

Great, thanks for the rapid response, @cbegeman!