E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Port ice_shelf_2d test cases #158

Closed cbegeman closed 3 months ago

cbegeman commented 10 months ago

This is largely a direct port of the ice_shelf_2d test cases from compass. The main changes are the following:

Checklist

cbegeman commented 10 months ago

@xylar This PR includes the ssh_adjustment framework I added. Please suggest changes if something different would be more convenient for isomip_plus.

cbegeman commented 10 months ago

@xylar Also, when you have a chance, let me know what you think of this restart test approach. I'd like to do something similar for the baroclinic channel test.

xylar commented 10 months ago

@cbegeman, thanks so much for this work! I'll take a look as soon as I can.

cbegeman commented 9 months ago

@xylar I think I've made all the changes you requested to the ssh_adjustment framework. Please let me know if there's anything else that is holding up your isomip_plus work. Otherwise, I'll move on to finishing up the rest of the tests in the group and docs and docstrings.

xylar commented 9 months ago

@cbegeman, I haven't had a chance to look over the latest updates today but I do think I have what I need for isomip_plus and you can finalize the docs and anything else remaining for this development when you have time.

cbegeman commented 9 months ago

@xylar Also, when you have a chance, let me know what you think of this restart test approach. I'd like to do something similar for the baroclinic channel test.

@xylar Whenever you have time

xylar commented 9 months ago

Oh, thanks! I lost track of that one.

xylar commented 9 months ago

The restart approach you have here looks great to me!

cbegeman commented 9 months ago

Testing

All new single_layer and z-star tests have been run on chrys with intel, impi.

cbegeman commented 9 months ago

@xylar I think this is all set to review. It took changing the number of vertical levels (from 20 to 50, though I didn't test values in between) to revive z-level (otherwise ssh_adjustment hangs).

cbegeman commented 9 months ago

@xylar When you have a chance, you can try the new setup_ssh_adjustment_steps approach with an ssh_forward class and an overridden compute_cell_count method.

xylar commented 9 months ago

@cbegeman, wow, that was fast work! I'll try this out again tomorrow.

xylar commented 8 months ago

@cbegeman, once you've had time to look over my latest comments, I'm happy to make a commit to this branch to make all those changes and then another one to update ice_shelf_2d with the changes. But I don't want to do that until I have the go-ahead from you.

cbegeman commented 8 months ago

@xylar All the changes look good to me. Please do push them; I think at this point you've done more testing than I have. Thanks for the thorough look at the code!

cbegeman commented 3 months ago

@xylar This is ready for your review. Thanks!

cbegeman commented 3 months ago

@xylar Thanks for your review and testing!