Remove namelist and streams from cosine bell init

E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice

BSD 3-Clause "New" or "Revised" License

6 stars 13 forks source link

Remove namelist and streams from cosine bell init #19

Closed xylar closed 1 year ago

xylar commented 1 year ago

They are not needed and are causing trouble because they don't get cached.

Checklist

[x] Testing comment in the PR documents testing used to verify the changes

xylar commented 1 year ago

Testing

I ran the QU and Icos versions of the cosine bell test case on Chrysalis. Both passed and don't contain the namelist.ocean files in their init directories, as expected.

I also ran with cached init using #18 and the analysis step works correctly, whereas it was failing with missing input files before this fix.

xylar commented 1 year ago

@cbegeman, could you give this a quick glance? No need to run any tests, just best to have another pair of eyes just in case I missed something obvious.

xylar commented 1 year ago

@cbegeman, Thanks for having a look!

From what I can see, the problem is still in compass. it looks like namelist.init and streams.init themselves are still here: https://github.com/MPAS-Dev/compass/tree/main/compass/ocean/tests/global_convergence/cosine_bell and the analysis test still expects a namelist file as an input: https://github.com/MPAS-Dev/compass/blob/main/compass/ocean/tests/global_convergence/cosine_bell/analysis.py#L47-L49

So we'll probably need to fix that in compass, too.

cbegeman commented 1 year ago

@xylar Hmm, that was unintentional. I opened a fixup PR here https://github.com/MPAS-Dev/compass/pull/540.