search

E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Bootstrap cleanup #216

Closed altheaden closed 2 months ago

altheaden commented 2 months ago

In this pull request I cleaned up the file deploy/bootstrap.py to make the code more readable and safer.

Checklist

altheaden commented 2 months ago

This PR is still in draft mode for a few reasons. The most recent commit is not working, which I am going to continue to investigate tomorrow. The commits before the broken commit have worked with my somewhat limited testing (building environment and running PR suire). I also still need to clean up the git history and update the API documentation.

altheaden commented 2 months ago

@xylar I took your suggestions, and I also renamed the instances of env_name to conda_env_name for the same reason.

xylar commented 2 months ago

Looks like CI isn't running but the fixes sound good. I'll check on this again tomorrow.

xylar commented 2 months ago

@altheaden, this looks good! I tested this with --recreate and without it, and with --check after doing a local merge with main to pick up #217. I didn't check any of the spack or --with* flags yet. I'm fine with merging this as it is and testing those other modes of deployment as they are needed.

xylar commented 2 months ago

BTW, there's no need to include these functions in the API docs. The deploy directory isn't really part of the polaris package so it's outside of the API we intend to document there.

altheaden commented 2 months ago

@xylar I did some cleanup to the git history and got rid of the dev comments. I think I'm happy with this for now, so feel free to take another look at things and then merge if you're happy with everything!

xylar commented 2 months ago

I'll merge this as soon as CI finishes.

xylar commented 2 months ago

Sorry for the hold up!