Set default `time_integrator` for Omega

E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice

BSD 3-Clause "New" or "Revised" License

6 stars 13 forks source link

Set default `time_integrator` for Omega #232

Closed xylar closed 5 days ago

xylar commented 2 weeks ago

In the manufactured_solution test, this needs to be RungeKutte4. (I'm not worrying about other tests yet.)

Checklist

[x] Testing comment in the PR documents testing used to verify the changes

xylar commented 2 weeks ago

This PR addresses the error found in https://github.com/E3SM-Project/Omega/issues/137.

xylar commented 2 weeks ago

Testing

I am able to run the 200km forward run from manufactured_solution with this change on Chrysalis, whereas it failed without this change. (The check for output.nc then fails as expected.)

xylar commented 2 weeks ago

@hyungyukang, would you be willing to review this fix as well? Perhaps you can test along with other testing you're doing anyway.

hyungyukang commented 2 weeks ago

@hyungyukang, would you be willing to review this fix as well? Perhaps you can test along with other testing you're doing anyway.

Yes. I will test this PR as well!

xylar commented 5 days ago

Thanks, @hyungyukang!