Ocean resources from config options

E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice

BSD 3-Clause "New" or "Revised" License

6 stars 13 forks source link

Ocean resources from config options #29

Closed xylar closed 1 year ago

xylar commented 1 year ago

Checklist

[x] Developer's Guide has been updated
[x] API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
[x] Documentation has been built locally and changes look as expected
[x] Testing comment in the PR documents testing used to verify the changes

xylar commented 1 year ago

@cbegeman, I think it is better to address your comment: https://github.com/E3SM-Project/polaris/pull/27#discussion_r1153686530 here in a separate PR before adding the baroclinic channel test group in #27.

cbegeman commented 1 year ago

@xylar Thanks for following up on my suggestion! I think this will be very convenient for developers. At some point we might want to move these config options from ocean.cfg to mpas-ocean.cfg, assuming that polaris has better performance. But in the near term, I'm guessing that we will want to compare performance on similar cpu core counts so I think it makes sense to have them in ocean.cfg for now.

xylar commented 1 year ago

Testing

I tested this comparing with main using the cosine_bell test suite. Results weren't BFB (not sure why) but they are within machine precision. I think that's okay.

xylar commented 1 year ago

@cbegeman, yes, I think you're exactly right. This could be moved right away to mpas_ocean.cfg but maybe we let it be for now.