E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Make versions of cosine bell with and without viz steps #65

Closed xylar closed 1 year ago

xylar commented 1 year ago

This merge also modifies the visualization so the central longitude is 180 degrees, not 0, so the cosine bell shape is in the center of the domain.

To accommodate this change, the remapping and global plotting has also been modified to support an arbitrary lower bound in longitude (in this case 0 degrees) rather than always using -180. Manually placing grid lines on plots did not seem to work with these changes but automatic grid line locations seem to be fine so this merge removes manual grid line locations.

Checklist

xylar commented 1 year ago

Testing

I set up and ran the new cosine_bell_with_viz steps and they did, indeed, run the _map and _viz steps for each resolution

xylar commented 1 year ago

@sbrus89, this is ready for your review when you have time.

xylar commented 1 year ago

Thanks for the reviews, @sbrus89. I'll update the docs and think about how to change the range of longitudes so the cosine bell is in the center.

xylar commented 1 year ago

Updated plot: final

xylar commented 1 year ago

@sbrus89, could you please have another look when you can?

altheaden commented 1 year ago

This seems to be going to the wrong logger:

Build time indices:   0% |                                     | ETA:  --:--:--
Build time indices: 100% |#####################################| Time:  0:00:00
Writing time series:   0% |                                    | ETA:  --:--:--
Writing time series: 100% |####################################| Time:  0:00:00
xylar commented 1 year ago

Thanks @altheaden. This was fixed in #82

xylar commented 1 year ago

@sbrus89, I'm going to go ahead and merge this one. Thank you for your earlier review. I think all your suggestions have been incorporated.