Closed xylar closed 1 year ago
I set up and ran the new cosine_bell_with_viz
steps and they did, indeed, run the _map
and _viz
steps for each resolution
@sbrus89, this is ready for your review when you have time.
Thanks for the reviews, @sbrus89. I'll update the docs and think about how to change the range of longitudes so the cosine bell is in the center.
Updated plot:
@sbrus89, could you please have another look when you can?
This seems to be going to the wrong logger:
Build time indices: 0% | | ETA: --:--:--
Build time indices: 100% |#####################################| Time: 0:00:00
Writing time series: 0% | | ETA: --:--:--
Writing time series: 100% |####################################| Time: 0:00:00
Thanks @altheaden. This was fixed in #82
@sbrus89, I'm going to go ahead and merge this one. Thank you for your earlier review. I think all your suggestions have been incorporated.
This merge also modifies the visualization so the central longitude is 180 degrees, not 0, so the cosine bell shape is in the center of the domain.
To accommodate this change, the remapping and global plotting has also been modified to support an arbitrary lower bound in longitude (in this case 0 degrees) rather than always using -180. Manually placing grid lines on plots did not seem to work with these changes but automatic grid line locations seem to be fine so this merge removes manual grid line locations.
Checklist
Testing
comment in the PR documents testing used to verify the changes