E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Add manufactured solution test group #72

Closed cbegeman closed 1 year ago

cbegeman commented 1 year ago

This PR adds the manufactured solution test group and the convergence test case as described in Bishnu et al.(2023). The test case depends on https://github.com/E3SM-Project/E3SM/pull/5725. The test currently "fails" with a convergence rate of 0.9 rather than ~2 due to https://github.com/E3SM-Project/E3SM/issues/5364.

Checklist

cbegeman commented 1 year ago

Testing

This test case has been run with intel, open-mpi on chrysalis.

cbegeman commented 1 year ago

@sbrus89 Thank you for adding those doc strings!

cbegeman commented 1 year ago

These are the updated figures: comparison convergence

cbegeman commented 1 year ago

@sbrus89 I think this is ready to go in when the E3SM PR gets merged.

cbegeman commented 1 year ago

Thanks @sbrus89! I implemented your suggestions

cbegeman commented 1 year ago

@xylar Are you seeing the python 3.8 CI test fail elsewhere?

xylar commented 1 year ago

@cbegeman, no, I haven't seen that anywhere else. The other python checks might also fail, they just got cancelled before they got a chance.

xylar commented 1 year ago

The error message wasn't super helpful but seemed like something that might not happen again if we rerun. Let's see what happens.

xylar commented 1 year ago

Yep just seems to have needed a rerun.

cbegeman commented 1 year ago

@xylar Are you ok with this merge? I just updated the e3sm submodule and retested the PR suite with all passes for existing tests.

xylar commented 1 year ago

@cbegeman, sure, go for it!