Closed cbegeman closed 1 year ago
This test case has been run with intel, open-mpi on chrysalis.
@sbrus89 Thank you for adding those doc strings!
These are the updated figures:
@sbrus89 I think this is ready to go in when the E3SM PR gets merged.
Thanks @sbrus89! I implemented your suggestions
@xylar Are you seeing the python 3.8 CI test fail elsewhere?
@cbegeman, no, I haven't seen that anywhere else. The other python checks might also fail, they just got cancelled before they got a chance.
The error message wasn't super helpful but seemed like something that might not happen again if we rerun. Let's see what happens.
Yep just seems to have needed a rerun.
@xylar Are you ok with this merge? I just updated the e3sm submodule and retested the PR suite with all passes for existing tests.
@cbegeman, sure, go for it!
This PR adds the manufactured solution test group and the convergence test case as described in Bishnu et al.(2023). The test case depends on https://github.com/E3SM-Project/E3SM/pull/5725. The test currently "fails" with a convergence rate of 0.9 rather than ~2 due to https://github.com/E3SM-Project/E3SM/issues/5364.
Checklist
api.md
) has any new or modified class, method and/or functions listedTesting
comment in the PR documents testing used to verify the changes