E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Logger cleanup and clarification #75

Closed altheaden closed 1 year ago

altheaden commented 1 year ago

This PR changes a few things concerning loggers. Some loggers in run/serial.py have been renamed for better code readability, indicating when they are logging to stdout vs an internal file. The log_filename attribute in Step has been explicitly set to None by default, as opposed to an empty string. And in general, some "compass" wording needed to be changed to "polaris".

Checklist

altheaden commented 1 year ago

I tested this with the pr suite against a baseline. The logging changed as expected and the baseline verification was successful.

altheaden commented 1 year ago

I also built the documentation locally and it looks as expected.

altheaden commented 1 year ago

Oops - I had to rebase, but now it's ready for review :)

altheaden commented 1 year ago

@xylar I fixed the formatting.