Closed altheaden closed 1 year ago
I tested this with the pr suite against a baseline. The logging changed as expected and the baseline verification was successful.
I also built the documentation locally and it looks as expected.
Oops - I had to rebase, but now it's ready for review :)
@xylar I fixed the formatting.
This PR changes a few things concerning loggers. Some loggers in
run/serial.py
have been renamed for better code readability, indicating when they are logging to stdout vs an internal file. Thelog_filename
attribute inStep
has been explicitly set to None by default, as opposed to an empty string. And in general, some "compass" wording needed to be changed to "polaris".Checklist
Testing
comment in the PR documents testing used to verify the changes