Separate creating parallel command and running command

E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice

BSD 3-Clause "New" or "Revised" License

6 stars 13 forks source link

Separate creating parallel command and running command #78

Closed altheaden closed 1 year ago

altheaden commented 1 year ago

Creating the command is now a process that can be called without running the command, for use when we wish to run the command elsewhere.

Checklist

[x] API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
[x] Testing comment in the PR documents testing used to verify the changes

altheaden commented 1 year ago

I tested this branch with the cosine bell suite, against a baseline, and everything ran as expected.

xylar commented 1 year ago

@altheaden, this is great! I'll test this now. Could you add a line just above or below this one: https://github.com/E3SM-Project/polaris/blob/main/docs/developers_guide/api.md?plain=1#L302 that refers to the new function? That way, it will show up in the automatically generated docs.

altheaden commented 1 year ago

@xylar Sure, I noticed that there are some other un-updated functions in that file (e.g. get_available_cores_and_nodes instead of get_available_parallel_resources, should I update all of the functions for polaris.parallel.py?

xylar commented 1 year ago

@altheaden, yes, please do!

altheaden commented 1 year ago

@xylar done, let me know if there is anything else I need to do!