E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Second error when a step fails #85

Closed xylar closed 1 year ago

xylar commented 1 year ago
Exception raised while running the steps of the test case
Traceback (most recent call last):
  File "/gpfs/fs1/home/ac.xylar/e3sm_work/polaris/extract-common-run-setup/polaris/run/serial.py", line 310, in _log_and_run_test
    _run_test(test_case, available_resources)
  File "/gpfs/fs1/home/ac.xylar/e3sm_work/polaris/extract-common-run-setup/polaris/run/serial.py", line 409, in _run_test
    _run_step(test_case, step, test_case.new_step_log_file,
  File "/gpfs/fs1/home/ac.xylar/e3sm_work/polaris/extract-common-run-setup/polaris/run/serial.py", line 495, in _run_step
    os.remove('step_after_run.pickle')
FileNotFoundError: [Errno 2] No such file or directory: 'step_after_run.pickle'
xylar commented 1 year ago

@altheaden, maybe this is one you can take care of? We want to change this line: https://github.com/E3SM-Project/polaris/blob/main/polaris/run/serial.py#L497 to something like:

        try:
            os.remove('step_after_run.pickle')
        except FileNotFoundError:
           pass
altheaden commented 1 year ago

@xylar I've made this fix but I am unable to test right now due to maintenance on Chrysalis. I've created a draft PR in the meantime, and it's linked to this issue.