Ignore nonexistent `step_after_run.pickle` file

E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice

BSD 3-Clause "New" or "Revised" License

6 stars 13 forks source link

Ignore nonexistent `step_after_run.pickle` file #86

Closed altheaden closed 1 year ago

altheaden commented 1 year ago

If a step fails, we want to remove its step_after_run.pickle file to indicate its failure. However, the file might be nonexistent, so in that case we should just go on to report the error and skip the removal.

Checklist

[x] Testing comment in the PR documents testing used to verify the changes

closes #85

altheaden commented 1 year ago

I haven't been able to complete testing on this because of maintenance on Chrysalis. When I am able to test, I will verify everything works and then mark this PR as ready for review.

xylar commented 1 year ago

@altheaden, this is great! You can add text like I did above:

closes #85

in the PR description so it automatically closes that issue when this PR gets merged.

xylar commented 1 year ago

I tested this (not using a baseline) by manually adding the word crash to the run() method in the initial_state step for test cases in the baroclinic_channel test group. As expected, I got failures in those test cases but with this fix I didn't see the issue reported in #85.

altheaden commented 1 year ago

OK, I ran the PR suite in this branch against a baseline and everything worked perfectly as expected.

altheaden commented 1 year ago

@xylar I am going to hold off from merging this in just in case you wanted to test anything else, but I believe it's good to go.

xylar commented 1 year ago

Thanks, @altheaden!