search

E3SM-Project / polaris

Testing and analysis for OMEGA, MPAS-Ocean, MALI and MPAS-Seaice
BSD 3-Clause "New" or "Revised" License
6 stars 13 forks source link

Remove `manufactured_soluiton` test case from suites #92

Closed xylar closed 1 year ago

xylar commented 1 year ago

I think we want to remove this test from our suites for now since it is failing "on purpose" (i.e. we know the MPAS-Ocean code needs to be fixed to allows the solution to converge at the desired rate) but this is confusing for those who are trying to use these suites to validate unrelated code.

Checklist

closes #89

xylar commented 1 year ago

@cbegeman, just wanted to make sure this is okay with you, too. I haven't tested this yet but will as soon as I can.

xylar commented 1 year ago

@altheaden, if you want, you can test if this fixes the problem you were having, but I'll test it as well.

altheaden commented 1 year ago

@xylar I did some testing last night in a branch with the exact change you've made here, and it worked perfectly.

xylar commented 1 year ago

Testing

I tested this with the pr suite and the test didn't run as expected. I think this and @altheaden's testing is enough.

xylar commented 1 year ago

@cbegeman, I know you're away having fun so don't worry about this one. We can turn this testing back on once you're back.

xylar commented 1 year ago

Thanks @sbrus89 and @altheaden!

cbegeman commented 1 year ago

@xylar and @altheaden Thanks for taking care of this while I was away. I don't have any problem with waiting to add this back to the suites until after we get convergence with MPAS-O.