timeseries doesn't allow `[[[custom_args]]]`

E3SM-Project / processflow

A workflow tool for the E3SM project

MIT License

6 stars 5 forks source link

Closed jhkennedy closed 5 years ago

jhkennedy commented 5 years ago

To specify the charge account on PBS systems, a custom PBS argument needs to be specified vial the [[[custom_args]]] subsubsection. For example, specifying the account at NERSC: https://e3sm-project.github.io/processflow/docs/html/quickstart.html#nersc-edison

However, the [[timeseries]] [post-processing] job doesn't allow for these arguments to be specified (unlike [[climo]]).

This may be an issue for other job types.

jhkennedy commented 5 years ago

Interestingly, it looks like timeseries should support [[[custom_args]]] because of this bit of logic: https://github.com/E3SM-Project/processflow/blob/2.2.0/jobs/timeseries.py#L21-L25

But, when run on the command line, I get this error:

$ python processflow -c joe.cfg -m 1
13:20:26: Entering setup
[-] custom_args is an unsupported timeseries data type
Error in setup, exiting

sterlingbaldwin commented 5 years ago

Ah, I see the issue. You correctly identified the issue with the verify_config method which should solve this problem.