E3SM-Project / processflow

A workflow tool for the E3SM project
MIT License
6 stars 5 forks source link

Restructure processflow for packaging best practices #149

Closed jhkennedy closed 5 years ago

jhkennedy commented 5 years ago

This:


Right now, the same tests pass from before the branch off of nightly ( dd99b42 ) to this refactor. However, since a lot of the tests make assumptions (users permissions, paths, and machine), I'm not able to run all the tests.

@sterlingbaldwin , due to the significance of the changes here, the best path to merging would likely be to rebase these changes on top of the current HEAD of nightly.

I can do the rebase and force-push the changes to this branch (updating this PR) once your:

  1. happy with these changes (at least enough to make the rebase worth it)
  2. Have nightly in a good paused-state (all changes you're working on pushed, and able to wait until this PR is merged to continue development)

And then we can see how the nightly test go.

jhkennedy commented 5 years ago

Oh and I should mention, I leveraged PyCharm heavily for this refactor, so all the imports were "optimized" -- unused imports dropped, one package-per-line, absolute imports, alphabetized, etc.

sterlingbaldwin commented 5 years ago

This is great! I just pushed what I hope will be the last substantial changes to get everything working again. Looking over your changes everything is straightforward and makes sense. I would say go ahead and do the rebase/merge. I'll use this for the testing on cori/blues/acme1 over the next couple days and make any tweaks if errors come up.

jhkennedy commented 5 years ago

Sounds good; will do!

sterlingbaldwin commented 5 years ago

re: testing. I'd like to setup some minimal test dataset on each of the machines so the tests can work anywhere, but its going to take a bit of work. Ideally that data could also then be used by new users for hello world examples.

jhkennedy commented 5 years ago

@sterlingbaldwin rebase is done! Give it a whirl and go ahead and merge it if you think it's ready.