Add more checks for decomps provided by user

E3SM-Project / scorpio

A high-level Parallel I/O Library for structured grid applications

Other

21 stars 16 forks source link

Add more checks for decomps provided by user #154

Open jayeshkrishna opened 5 years ago

jayeshkrishna commented 5 years ago

Add more checks on the decompositions provided by the user

Check for -ve values in the decomposition
Check if the values are monotonically increasing

Since some of these checks are costly we should also consider adding a "DEBUG " or "EXTRA_CHECK" mode where we perform more costly user argument checking etc. As part of this issue we could move any current user arg checks that are costly under this mode.

jayeshkrishna commented 5 years ago

PR #196 adds test for decompositions with offsets that are not monotonically increasing (they work with PIO2 but we might still need to investigate if it affects the performance - and possible warn the user or sort the data ourselves)