search

E3SM-Project / scorpio

A high-level Parallel I/O Library for structured grid applications
19 stars 16 forks source link

Define PIO_64BIT_DATA with NC_64BIT_DATA from NetCDF/PnetCDF #508

Closed dqwu closed 1 year ago

dqwu commented 1 year ago

Due to historical reasons related to older versions of NetCDF and PnetCDF, PIO_64BIT_DATA in SCORPIO was hard-coded to a specific value. However, this causes a problem as it is different from the NC_64BIT_DATA definition in newer versions of NetCDF (4.4.0 or higher) and PnetCDF (1.6.0 or higher). This issue is demonstrated through new C unit tests included in this PR.

To address this issue, the minimum required version of NetCDF is being bumped from 4.3.3 to 4.4.0, which will allow us to safely define PIO_64BIT_DATA as NC_64BIT_DATA.

dqwu commented 1 year ago

older tests were testing NetCDF types instead of PIO types and that is being fixed in this commit?

OK, I have updated the commit message.