E3SM-Project / scorpio

A high-level Parallel I/O Library for structured grid applications
19 stars 16 forks source link

error code checking #520

Open wkliao opened 1 year ago

wkliao commented 1 year ago

This error code checking is problematic. Assuming it is possible that ierr can be different among processes, checking only root's ierr at line 1429 after bcast at line 1422 may not detect a failure on other processes.

https://github.com/E3SM-Project/scorpio/blob/ac679a546c2345e1b94e0fbb54d06115b91e792c/src/clib/pio_nc.c#L1421-L1434