search

E3SM-Project / scorpio

A high-level Parallel I/O Library for structured grid applications
Other
21 stars 16 forks source link

Replace _FillValue with NC_FillValue #613

Open jayeshkrishna opened 1 month ago

jayeshkrishna commented 1 month ago

Newer versions of the NetCDF library only supports NC_FillValue instead of _FillValue to avoid conflicts with the C++ library headers. We also need to move (with appropriate config checks) to using NC_FillValue.

Also see https://github.com/Unidata/netcdf-c/issues/2858 , https://github.com/Unidata/netcdf-c/blob/main/RELEASE_NOTES.md

wkliao commented 1 month ago

I think the safest way for users of NetCDF4 is to use string "_FillValue" directly. That way Scorpio can be built with any NetCDF4 versions.