search

E3SM-Project / scream

Fork of E3SM used to develop exascale global atmosphere model written in C++
https://e3sm-project.github.io/scream/
Other
80 stars 55 forks source link

SHOC: out of bounds #400

Closed ambrad closed 4 years ago

ambrad commented 4 years ago

At this line, https://github.com/E3SM-Project/scream/blob/0923ce13163e9029962ae967f53e5eb531ba8939/components/cam/src/physics/cam/shoc.F90#L3315 thv_zi is declared as having nlev levels, but it should be nlevi. Its use in the subroutine assumes nlevi. The caller has nlevi levels, though, so it's a problem in DEBUG builds only.

ambrad commented 4 years ago

@pressel this looks like something from a refactor PR.

pressel commented 4 years ago

Thanks, @ambrad you are correct. Fixing this now.

pressel commented 4 years ago

Ths bug was fixed with PR #402.