search

E3SM-Project / spack

A flexible package manager that supports multiple versions, configurations, platforms, and compilers.
https://spack.io
Other
1 stars 2 forks source link

Rebase onto v0.19.0 #9

Closed xylar closed 1 year ago

xylar commented 1 year ago

The main repo just released https://github.com/spack/spack/releases/tag/v0.19.0

I would like to rebase when the time is right.

xylar commented 1 year ago

@ikalash, if I were to rebase on Sunday or Monday, would that be okay?

ikalash commented 1 year ago

I don't see why not. Thanks for the heads up. We'll see from my nightly tests if everything is OK with the build post-rebase.

xylar commented 1 year ago

Great! The rebase went pretty well. My branch is here: https://github.com/xylar/spack/tree/rebase_onto_v0.19.0 The only "difficulties" were that they have changed all ' to ", which makes for a lot of meaningless merge conflicts. I didn't try to change trilinos-for-albany to match but I did in albany itself.

xylar commented 1 year ago

Okay, the rebase is done. @ikalash, let me know if there are any unpleasant surprises.

ikalash commented 1 year ago

Thanks @xylar ! Should know tomorrow when the nightlies run.

ikalash commented 1 year ago

Just to follow up, my nightly spack build is good following the rebase/merge.

xylar commented 1 year ago

That's great to hear! After fixing a few issues with my yaml file, I was able to build Albany on Perlmutter again after the rebase and some module updates. Things worked without a hitch on Chrysalis but I'm having trouble on Anvil and again I suspect I just need to update my yaml file. I haven't tried Compy yet so that could go either way. Fingers crossed. But the fact that I could build Albany on Perlmutter and Chrysalis and your tests went fine suggests that I shouldn't see any Albany-specific problems anywhere else.