search

E3SM-Project / transport_se

Atmosphere transport mini app
1 stars 1 forks source link

Most tracers are set to 0 #8

Closed mt5555 closed 9 years ago

mt5555 commented 9 years ago

David, a couple of issure: The current code, when setting the velocity, calls "set_elemement_state()" each timestep. This also sets the tracers, but I think only at the future timelevel, which is then overwritten by the actual tracer timestep. But I wanted to make sure this was correct?

Second question: where is the best place to set the values of tracers 5..qsize? If it was done in "set_element_state" it would automatically apply to all test cases, but this doesn't seem like a good idea.

mt5555 commented 9 years ago

set_element_state() only sets the tracers when time==0. So that answers the first question above.

mt5555 commented 9 years ago

FYI: dcmip1-1 only sets tracers 1-4. dcmip1-2 only sets tracer 2.

mt5555 commented 9 years ago

resolved https://github.com/ACME-Climate/transport_se/commit/e7f8f634b022fff60cfd0588aa4b4103075ed31f