E3SM-Project / v3atm

Fork of E3SM for testing v3 atm changes
Other
0 stars 5 forks source link

Link MOSAIC nitrate and MAM5 strat sulfate treatment #15

Closed mingxuanwupnnl closed 2 years ago

mingxuanwupnnl commented 2 years ago

This PR provides the capability of running MOSAIC nitrate and MAM5 stratospheric sulfate treatment together. This PR is a stealth feature which does not turn on MOSAIC and MAM5 by default.

Two conditional compilation if statements: MODAL_AERO_5MODE and MOSAIC_SPECIES

The code modifications are mainly for:

  1. Moving conditional compilation if statements MODAL_AERO_5MODE together with MODAL_AERO_4MODE_MOM, because MAM5 only adds a strat coarse mode compared to MAM4. Minimize the code changes so that only

( MODAL_AERO_4MODE_MOM || MODAL_AERO_5MODE ) && MOSAIC_SPECIES and ( MODAL_AERO_4MODE_MOM || MODAL_AERO_5MODE ) work for most places.

  1. Adding chem_mech.in files for chemUCI-MOSAIC and chemUCI-MOSAIC-MAM5.

Test suite results https://acme-climate.atlassian.net/wiki/spaces/NGDAP/pages/3523149825/Couple+MOSAIC+and+MAM5+strat+sulfate

It is BFB (stealth) for chemUCI only simulations. test suites results compared with NGD_v3atm baseline (./create_test $TESTNAMES --compare -b NGD_v3atm): /lcrc/group/e3sm/ac.mwu/scratch/chrys/

PASS SMS_Ln5.ne30pg2, SMS_Ln.ne4pg2 ERS_Ln11.ne30pg2, ERS_Ln9.ne4pg2, ERS_ln11_P512x1.ne30.pg2 REP_Ln9 (FAIL for TPUTCOMP Error: TPUTCOMP: Computation time increase > 10% from baseline) PET_Ln5_P256x2.ne30pg2

FAIL PET_Ln5.ne30pg2 PET_Ln5.ne4pg2 PEM_Ln5.ne4pg2 (FAIL RUN time; PEND COMPARE_base_modpes) PEM_Ln9.ne30pg2

It is BFB (stealth) for chemUCI-MOSAIC simulations.

It is not restart-BFB for chemUCI-MOSAIC-MAM5, and 1x10 and 2x5 test runs for NGD_v3atm branch also show non restart-BFB for MAM5 only simulations.