Quick fix for non-BFB results when all ZM enhancements are turned off

E3SM-Project / v3atm

Fork of E3SM for testing v3 atm changes

Other

0 stars 5 forks source link

Quick fix for non-BFB results when all ZM enhancements are turned off #23

Closed crterai closed 1 year ago

crterai commented 1 year ago

This PR makes fixes to the ZM microphysics to make sure results are BFB when ZM enhancements are turned off. It also includes some code cleanup to make sure all variables are explicitly declared.

crterai commented 1 year ago

@mingxuanwupnnl , Yes, there were a couple sections within the code that needed zm_microp flags, but which did not exist. Since being added, they will only be run if zm_microp = .true. and will not in the default case.

wlin7 commented 1 year ago

Merged to NGD_v3atm. Tests confirmed the fix worked as expected.