search

E3SM-Project / v3atm

Fork of E3SM for testing v3 atm changes
Other
0 stars 5 forks source link

O3 production/loss diags modification #32

Closed hsiangheleellnl closed 1 year ago

hsiangheleellnl commented 1 year ago

Since O3 production and loss terms are changed due to the new chemistry mechanism file, the chem diagnostics need to modify as well.

Where nonconvergent in the implicit solver for O3 production and loss after new SOA reactions, the O3 production and loss are forced to zero. [NBFB]

tangq commented 1 year ago

@hsiangheleellnl , since you modified the chemistry mechanism file (named the two reactions), that file should be included in this PR.

tangq commented 1 year ago

@hsiangheleellnl , the PR should be good to go after replacing the hard-coded avogadro number with that defined in mo_constants as I suggested above.

wlin7 commented 1 year ago

@hsiangheleellnl , @tangq , Does this PR cause all simulations results to differ? After #32, #55, #56, the tests are NBFB. #55 with ZMmicro on is BFB. #56 with time step change, I didn't expect to affect ne30pg2 tests.

tangq commented 1 year ago

@wlin7 , #56 should be BFB. I am not sure about #32.

@hsiangheleellnl , is #32 BFB? Or it changes results?