search

E3SM-Project / v3atm

Fork of E3SM for testing v3 atm changes
Other
0 stars 5 forks source link

port land bugfix from E3SM master #67

Closed mahf708 closed 1 year ago

mahf708 commented 1 year ago

Port landbug fix from E3SM master. https://github.com/E3SM-Project/E3SM/pull/5552

wlin7 commented 1 year ago

@mahf708 , did you have a chance to check the impact of this change in v3atm repo? That fix seems to only become necessary after merging UCI-chem to master (fixing rapid ozone loss).

mahf708 commented 1 year ago

id you have a chance to check the impact of this change in v3atm repo? That fix seems to only become necessary after merging UCI-chem to master (fixing rapid ozone loss).

Yes, I am currently testing. That's why I ported it here. This bug fixed by this PR was hypothesized to be potentially a contributor to machine differences we are seeing, so I am trying to study that more carefully. I will report the results of my analysis in a few hours. Almost done on chrysalis, but ways to go on compy...

mahf708 commented 1 year ago

Update: this PR can be considered non-climate-changing, but it is obviously non-BFB. More details later.