search

E3SM-Project / v3atm

Fork of E3SM for testing v3 atm changes
Other
0 stars 5 forks source link

Fix threading and pe-layout NBFB issues in UCI-chem codes #69

Open wlin7 opened 1 year ago

wlin7 commented 1 year ago

. Fixed array shape pdeldry in lin_strat_chem.F90 that would failed debug mode . Replaced ch4max calculation with a global constant. A tentative fix for NBFB that would otherwise have . Fixed codes for surface emission section in mo_gas_phase_chemdr.F90 that cause round-off NBFB when threading or pe-layout changes

[NBFB]

wlin7 commented 1 year ago

@keziming , @jinboxie , though these fixes are already merged in master, it is still useful to also apply to NGD_v3atm, for testing new branches based off NGD_v3atm. Please help take a look if I mis-typed anything. You may refer to the same block of codes in E3SM master as a comparison.

keziming commented 1 year ago

@wlin7 Thank you for this explanation.

wlin7 commented 1 year ago

Closed and use #70 instead.