Replace image diff tests with metrics tests

E3SM-Project / zppy

E3SM post-processing toolchain

BSD 3-Clause "New" or "Revised" License

6 stars 15 forks source link

Replace image diff tests with metrics tests #536

Open forsyth2 opened 11 months ago

forsyth2 commented 11 months ago

Request criteria

[X] I searched the zppy GitHub Discussions to find a similar question and didn't find it.
[X] I searched the zppy documentation.
[X] This issue does not match the other templates (i.e., it is not a bug report, documentation request, feature request, or a question.)

Issue description

Replace image diff tests with metrics tests. See https://github.com/E3SM-Project/e3sm_diags/issues/756 for more information.

forsyth2 commented 3 months ago

@golaz pointed out that the image checker tests are quite useful for making sure no plots disappear (e.g., only showing 1 or 2 of the 3 plots on a comparison page in diags), as once happened. That said, it's possible just testing metrics could also accomplish this.