Comment for _level is incorrect

EA31337 / EA31337-classes

📦📈 EA31337 framework (MQL library for writing trading Expert Advisors, indicators and scripts)

https://ea31337.github.io/EA31337-classes

GNU General Public License v3.0

186 stars 98 forks source link

Comment for _level is incorrect #638

Closed hrdrq closed 2 years ago

hrdrq commented 2 years ago

I guess _level is not bitwise AND operation, and is percentage value? https://github.com/EA31337/EA31337-classes/blob/86dc933a1ecd854c93b9b98e87326507d8e58188/Strategy.mqh#L1014-L1042

kenorb commented 2 years ago

Yes, it's incorrect. It's not bitwise, but a float. It's not necessary a percentage (it's used as a percentage of indicator value change where there is no primary usage), it depends on the strategy (can be used for anything). For example in RSI, can be used to set the levels of signal (e.g. 20 level means 30 vs 70). Unfortunately a lot of block comments are outdated, so they need to be corrected at some point.

hrdrq commented 2 years ago

Thanks. Is there an effective way to report incorrect comments like it?

kenorb commented 2 years ago

Thanks. Is there an effective way to report incorrect comments like it?

You can create issue (as you did). Which should be fine.
Propose an edit (there is an option to: Edit this file).
Send the pull request with the change suggestions.
Or put a comment in the corresponding commit.

kenorb commented 2 years ago

Fixed in v2.010.