search

EA31337 / EA31337-strategies

🤖📈 EA31337 strategies.
https://ea31337.github.io/EA31337-strategies
GNU General Public License v3.0
79 stars 52 forks source link

Fixes #1: AppVeyor CI #4

Closed ghost closed 6 years ago

ghost commented 6 years ago

I corrected some problems with the existing AppVeyor file, but now I get errors about file includes. Do you have any idea where these files are supposed to be?

ghost commented 6 years ago

The log can be found here: https://ci.appveyor.com/project/ryu0/ea31337-strategies/build/1.0.1

kenorb commented 6 years ago

Can you clone it the same as Travis CI does? So:

git clone --depth=50 https://github.com/EA31337/EA31337-strategies.git EA31337/EA31337-strategies
git submodule update --init --recursive

Which seems to work for Travis.

kenorb commented 6 years ago

Ah, ok, you cloned it right. Sorry, was checking the other log.

ghost commented 6 years ago

Yes, it appears to fail because this is a pull request and not a direct commit. I'll see if I can correct that later.

kenorb commented 6 years ago

I think that's correct. The task was to make Appveyor fail on the compilation of files which it didn't before. So as far the compilation log file consist of lines with error or warning, the test should fail.

I'll be working on fixing these files later on, so no worries.

kenorb commented 6 years ago

Question, do you really need to clone the repo? Isn't Appveyor already doing it? Or it's a problem with the missing submodules?

ghost commented 6 years ago

AppVeyor was already cloning the repo, but it didn't automatically grab the submodules at the same time. I had to do that for there to be any code for metaeditor to compile.

ghost commented 6 years ago

The only solution I found was to override the clone method with a script.

ghost commented 6 years ago

See here: https://github.com/appveyor/ci/issues/899

kenorb commented 6 years ago

Also question, does findstr "error warning" includes error or warning lines? As it's using the phrase together "error warning" whereas there are no any lines with error warning. So I was wondering whether it'll succeed on no errors.