EASOL / easol

EASOL - A New Way to Open Learning with Ed-Tech
http://easol.org
GNU Affero General Public License v3.0
1 stars 4 forks source link

Year filter drop-down values #329

Closed edgarf closed 7 years ago

edgarf commented 8 years ago

@regiscamimura, could you please review what are the Year values currently fed into that drop-downs on different listing views.

regiscamimura commented 8 years ago

@edgarf There are different methods for the year values:

edgarf commented 8 years ago

@regiscamimura Thanks.

edgarf commented 8 years ago

@regiscamimura let's please just not forget about adding those 2 additional system variables (for current school year + term).

edgarf commented 8 years ago

Regis - would this be possible to also show options from the result for Students, Section, Attendance and Analytics? Also in Management -> School -> Edit. When configuring values. Where are thee years taken from?

Thanks!

regiscamimura commented 8 years ago

@edgarf I got it done for Students, Section, and Attendance, but for analytics, we'll need to think of a better solution. That's because we retrieve a chunk of data at a time, so we don't really know all the year options from the beginning. We can probably take advantage and find a better solution for the performance issues and API usage there, unless the API have a method to retrieve all possible years. Thoughts?

Regarding the management -> school -> edit section, the year options are hard-coded and limited to be 2010, 2011, 2012, and 2013. How would you want the options to be set?

edgarf commented 8 years ago

The best way is to only show those years, which are in the dataset. How much time would be needed to do that?

regiscamimura commented 8 years ago

@edgarf You mean show years in the dataset for the analytics? For all other views, it now show years in the dataset indeed, but for analytics we have a problem because we just get a small portion of the dataset at a time, so we don't really know what year options we're going to have. I'm not sure how we can retrieve all the possible years at once -- I actually do, but it would cause performance issues. Do we have any docs on the analytics API? I might find another method.

Other thing I can do is to add year options as the dataset loads, but be aware that we would be only be able to filter results that are already loaded, know what I mean?

Or do you mean you want the years option in management->school->edit section to somehow read from the database and get options from there?

edgarf commented 8 years ago

@regiscamimura - if it's already everywhere except the Analytics, then it's good enough already. Sorry for the confusion. That's already pushed?

regiscamimura commented 8 years ago

yes, already pushed