search

EASOL / easol

EASOL - A New Way to Open Learning with Ed-Tech
http://easol.org
GNU Affero General Public License v3.0
1 stars 4 forks source link

Add ability to select Term in Attendance View #351

Closed edgarf closed 8 years ago

edgarf commented 8 years ago

Add ability to select Term in Attendance View. Only allow to select from the existing ones in the dataset below.

regiscamimura commented 8 years ago

@edgarf hmm I don't really get what field would "Term" be. There is no such column in the dataset below... would term be "present/excused/unexcused"?

edgarf commented 8 years ago

@regiscamimura Sorry for lack of information on this. I have meant "Term" as "Fall Semester", "Spring Semester". Can you check how the calculations are done now? Is the full SchoolYear taken?

Additionally, there is one more update (in the system in overall needed). It's not very clear what SchoolYear is in mind. For example if it says "2014", Does it mean 2013-2014 or 2014-2015? We have an assumption that it is YEAR - (YEAR+1), so in situation with 2014 (2014-2015). Could you please 1. Validate whether my thoughts are correct 2. Update labels on all filter options and dataset views to show the interval instead of 1 integer value? We'd like to do it without changing data in the db.

regiscamimura commented 8 years ago

@edgarf Done and pushed to 351

regiscamimura commented 8 years ago

@edgarf the SchoolYear piece is still pending though. Working on it.

edgarf commented 8 years ago

@regiscamimura - do you think you'd be able to push the rest of the task today? Thanks!

regiscamimura commented 8 years ago

@edgarf Before getting it done, I'm not much sure neither if 2014 means 2013-2014 or 2014-2015, and we need to get it figured out. For the attendance view, we have records which School Year is 2011, but the EventDate is from 2010, so it seems when you say 2011, you mean 2010-2011.

Also, in the table for StudentSchoolAssociation, we have records with SchoolYear being 2011, while the "EntryDate" is from 2010. So it seems that 2011 mean when the school year ends, so that would be 2010-2011.

Well, those are still assumptions I made just by looking over the data in the DB. Can we trust the data is correct? Can someone confirm my understanding?

edgarf commented 8 years ago

@regiscamimura - sorry for not getting back to you sooner. Can you tell me whether you were looking into the easol-dev or easol-dev-staging2?

regiscamimura commented 8 years ago

@edgarf I was looking into easol-dev

edgarf commented 8 years ago

@regiscamimura - Let's do it like this - " $School_Year "-" ($School_Year+1)" I talked with people on our team and they asked to use this. easol-dev is using a little bit different ingestion process. So it should be good with the way proposed.

edgarf commented 8 years ago

@regiscamimura - let me know when we can do this.

regiscamimura commented 8 years ago

@edgarf This is done, and pushed to branch 329. The issue #329 it's related to year filter dropdowns so I put it together. Not sure if the analytics portion fits the changes (i.e., should we use year - year + 1 as labels on it?), so it's just skipped. Let me know your thoughts on this.

edgarf commented 8 years ago

Thank you, I will check re Analytics and let you know.

edgarf commented 8 years ago

@regiscamimura, thanks for the update. Let's also add this yea-year layout for all other places where it appears. For example here below: image

regiscamimura commented 8 years ago

@edgarf You mean to make the "Year" column in the table below to also show 2011-2012 instead of just 2011?

edgarf commented 8 years ago

Correct. And everywhere else, where is it mentioned.

On 09 Jun 2016, at 15:33, Regis Camimura notifications@github.com wrote:

@edgarf https://github.com/edgarf You mean to make the "Year" column in the table below to also show 2011-2012 instead of just 2011?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EASOL/easol/issues/351#issuecomment-224880809, or mute the thread https://github.com/notifications/unsubscribe/AE-MvOqMFhOGj9qFqu9kcB_5RhbyMRbfks5qKAgBgaJpZM4IgX-H.

regiscamimura commented 8 years ago

@edgarf For the assessment views, we do have a filter for Year. But in that context, Year does not refers to a School Year, but to the "Version" column, so I'm not sure if using values like 2007-2008 would be appropriated here. Unless we also consider "Version" being 2007 to actually mean 2007-2008. Thoughts?

regiscamimura commented 8 years ago

@edgarf and regarding the analytics area, I see now that makes perfect sense to use the school year range like 2011-2012, so I pushed that to the branch 351.

edgarf commented 8 years ago

Hi @regiscamimura - let's convert "Version" to the x-y combination too. Thank you!

regiscamimura commented 8 years ago

@edgarf Just did.

regiscamimura commented 8 years ago

@edgarf btw, branch 351 is merged with development, you should have no problem on merging back development with 351